upgrade go modules #651
Merged
upgrade go modules #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezes
commented
Feb 19, 2025
| // Pin kuberesolver/v5 to support new grpc version. Need to upgrade kuberesolver version on weaveworks/common. | ||
| github.com/sercand/kuberesolver/v4 => github.com/sercand/kuberesolver/v5 v5.1.1 | ||
|
|
||
| github.com/thanos-io/thanos => github.com/thanos-io/thanos v0.0.0-20240723122114-639bf8f21649 | ||
| github.com/thanos-io/thanos => github.com/frezes/thanos v0.0.0-20250219031509-186a9979b843 |
There was a problem hiding this comment.
临时先用我当前repo，等待 thanos-io/thanos#8112 合入
There was a problem hiding this comment.
升级这个的目的是为了解决什么问题？thanos-io/thanos#8112
我看这个 PR 的 ci 失败了
There was a problem hiding this comment.
thanos 里 prometheus 依赖库升级不彻底，导致 whizard 依赖更新也出问题，等稍后有时间会修复 CI 问题
There was a problem hiding this comment.
上游 CI 报错应该不是我这个 PR 引起的，而且已经 approve 了
Signed-off-by: frezes <[email protected]>
Signed-off-by: frezes <[email protected]>
junotx
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.