This repository has been archived by the owner on Aug 25, 2022. It is now read-only.
Use ms constants only if we have curl >= 7.16.2 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taluu
changed the title
guillaumepotier
added a commit
that referenced
this pull request
Jun 9, 2014
Use ms constants only if we have curl >= 7.16.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should avoid any warnings, as the constants
CURLOPT_CONNECTTIMEOUT_MSandCURLOPT_TIMEOUT_MSare only available on curl >= 7.16.2If we are below that version (should we still support it ? it is getting kinda old...), use the constants in seconds rather than milliseconds (
CURL_CONNECTTIMEOUTandCURL_TIMEOUT), with a multiplication per 1000 for thehandshakeTimeoutparameter.And I also took the liberty to remove the
requirein top of theClientclass. We're using composer, so autoloading is not really our problem.poke @guillaumepotier