This repository has been archived by the owner on Aug 25, 2022. It is now read-only.
Authorization and handshaking #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elephant.io rocks!. I implemented socket.io Authorization https://github.com/LearnBoost/socket.io/wiki/Authorizing on my project and wanted to share my solution as a way of saying thank you :)
|
Hi, thanks for your PR. Looking at it, that seems related to #34 one, which is a bit more generalist because not auth-related and allowing more generally to add query params to url. What do you think ? Best |
|
Closing this one, as #36 did the job and is more flexible (not surcharging the constructor with yet another argument...) Thanks for the job though :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elephant.io rocks!. I implemented socket.io Authorization https://github.com/LearnBoost/socket.io/wiki/Authorizing in my project and wanted to share my solution as a way of saying thank you :)