fix(Android): change name of headerBackButtonClicked event (software-…

…mansion#2015) ## Description When running app, there is a soft error thrown with such message: ![image](https://github.com/software-mansion/react-native-screens/assets/32481228/47285229-ca19-438d-bca1-9f93187108bf) and it is true that only this event does not stick to the convention, so we should change it. ## Changes Removed `Event` suffix in `topHeaderBackButtonClickedEvent` since it should not be there. --------- Co-authored-by: Tymoteusz Boba <[email protected]>
WiseOwlTech · Oct 9, 2024 · 42f6ec4 · 42f6ec4
1 parent 372776f
commit 42f6ec4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/android/src/main/java/com/swmansion/rnscreens/events/HeaderBackButtonClickedEvent.kt b/android/src/main/java/com/swmansion/rnscreens/events/HeaderBackButtonClickedEvent.kt
@@ -13,6 +13,6 @@ class HeaderBackButtonClickedEvent(surfaceId: Int, viewId: Int) : Event<ScreenAp
     override fun getEventData(): WritableMap? = Arguments.createMap()
 
     companion object {
-        const val EVENT_NAME = "topHeaderBackButtonClickedEvent"
+        const val EVENT_NAME = "topHeaderBackButtonClicked"
     }
 }
diff --git a/src/fabric/ScreenNativeComponent.ts b/src/fabric/ScreenNativeComponent.ts
@@ -69,6 +69,7 @@ export interface NativeProps extends ViewProps {
   onHeaderHeightChange?: BubblingEventHandler<HeaderHeightChangeEvent>;
   onTransitionProgress?: BubblingEventHandler<TransitionProgressEvent>;
   onGestureCancel?: BubblingEventHandler<ScreenEvent>;
+  onHeaderBackButtonClicked?: BubblingEventHandler<ScreenEvent>;
   sheetAllowedDetents?: WithDefault<SheetDetentTypes, 'large'>;
   sheetLargestUndimmedDetent?: WithDefault<SheetDetentTypes, 'all'>;
   sheetGrabberVisible?: WithDefault<boolean, false>;
@@ -96,7 +97,6 @@ export interface NativeProps extends ViewProps {
   navigationBarColor?: ColorValue;
   navigationBarHidden?: boolean;
   nativeBackButtonDismissalEnabled?: boolean;
-  onHeaderBackButtonClicked?: BubblingEventHandler<ScreenEvent>;
 }
 
 export default codegenNativeComponent<NativeProps>('RNSScreen', {