Bug fixes: -ext doesn't ever match lowercase extensions, regExExcludes list grows on updates #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the command line is parsed, extensions are converted to uppercase and placed in a dictionary. However, at comparison time, the extension is not uppercased, so lowercase extensions never match and are always output into the Paraffin output file.
When updating an existing fragment fiel, there was no check for an existing RegExExclude entry, so an update operation would happily add a duplicate item and the <RegExExclude> list grows on each update. Added a check to ensure items in the list are unique.
|
Great catches! Merged and thanks for the patches. |
JohnWintellect
added a commit
that referenced
this pull request
Dec 7, 2012
Bug fixes: -ext doesn't ever match lowercase extensions, regExExcludes list grows on updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bugs that I frequently encounter are fixed.
When the command line is parsed, extensions are converted to uppercase
and placed in a dictionary. However, at comparison time, the actual extension
is not uppercased, so lowercase file extensions never match and are always
output into the Paraffin output file.
I did not check the other exclusion functions to see if they have a similar problem.
Also, the regExExcludes list grows on each update because there is no check to see if an existing RegExExclude is re-specified on the update command line. Other lists are checked, but not this one. This is fixed.