Rename object_id to message_id #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.4 prints the following message when redefining object_id: ``` warning: redefining 'object_id' may cause serious problems ``` According to fragment.rb, winrm’s object_id is the ID of the message, so let’s rename it to message_id. message_id was not used before, and no calls to object_id referred to Ruby’s, so I’ve naively replaced all occurrences of object_id by message_id.
|
@pcai can you take a look please 🙏 ? |
|
@mwrock can you take a look please ? 🙏 |
|
Sorry for the delay, I approved the check to run and it seems safe so I'll merge it if the tests pass. I'm unsure what our usual policy here is, but this is probably not part of an explicit public api - so I am gathering that this isn't going to be considered a breaking change, right? Even though in theory it could break someone who specifically depends on this? |
|
Thank you for the contribution. Tests pass, and I couldn’t find any references to object_id in any repo in the organization, so this seems safe to me |
|
Thanks @pcai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.4 prints the following message when redefining object_id:
According to fragment.rb, winrm’s object_id is the ID of the message, so let’s rename it to message_id.
message_id was not used before, and no calls to object_id referred to Ruby’s, so I’ve naively replaced all occurrences of object_id by message_id.
I do not have a Windows machine to test, but this change should be safe unless external calling code use these methods.