Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Menu Bar as a Toolbar #2400

Merged
merged 16 commits into from
Aug 15, 2024
Merged

Implement Menu Bar as a Toolbar #2400

merged 16 commits into from
Aug 15, 2024

Conversation

sdottaka
Copy link
Member

@sdottaka sdottaka commented Aug 1, 2024

This PR implements the menu bar as a toolbar, allowing it to be positioned freely.
However, the main purpose is to prepare for dark mode support and moving tabs to the title bar.
image
image
image

Src/CommandBar.h Fixed Show fixed Hide fixed
Src/CommandBar.cpp Fixed Show fixed Hide fixed
Src/MenuBar.cpp Fixed Show fixed Hide fixed
Src/MenuBar.h Dismissed Show dismissed Hide dismissed
Src/MenuBar.h Dismissed Show dismissed Hide dismissed
@sdottaka sdottaka changed the title WIP Implement Menu Bar as a Toolbar Aug 15, 2024
@sdottaka sdottaka marked this pull request as ready for review August 15, 2024 11:02
@sdottaka sdottaka merged commit d78d4a7 into master Aug 15, 2024
4 checks passed
@sdottaka sdottaka deleted the commandbar branch August 15, 2024 11:12
@sdottaka sdottaka added this to the v2.16.43 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant