unicoder.cpp light performance improvements #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheckForInvalidUtf8 performance improvement
light performance improvements
space-tab change
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (uc >= 0xd800 && uc < 0xdc00) | ||
| { | ||
| ++it; | ||
| if (it != tstr.end()) | ||
| if (++i != len) |
Check notice
Code scanning / CodeQL
For loop variable changed in body
|
Thank you! |
tjmprm77
reviewed
Nov 26, 2022
| @@ -792,10 +789,10 @@ void buffer::resize(size_t newSize) | |||
| { | |||
| if (capacity < newSize) | |||
| { | |||
| capacity = newSize; | |||
| unsigned char *tmp = static_cast<unsigned char *>(realloc(ptr, capacity)); | |||
There was a problem hiding this comment.
I'm sorry if my understanding is wrong, but I think this process needs to be modified as follows.
unsigned char *tmp = static_cast<unsigned char *>(realloc(ptr, newSize));
sdottaka
added a commit
that referenced
this pull request
Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.