Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More information in spool tab and spool selector, progress bar indicator for sidebar #26

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MrBullet
Copy link

@MrBullet MrBullet commented Dec 20, 2024

changed table names in ui and added remaining length in meters. also changed spool selector's spool names to add remaining length.

only changed 5 files
octoprint_SpoolManager\static\css\SpoolManager.css
octoprint_SpoolManager\static\js\SpoolManager.js
octoprint_SpoolManager\templates\SpoolManager_dialog_selectSpool.jinja2
octoprint_SpoolManager\templates\SpoolManager_sidebar.jinja2
octoprint_SpoolManager\templates\SpoolManager_tab.jinja2
octoprint_SpoolManager\templates\SpoolManager_tab_spoolSelection_comp.jinja2

image
image
image

changed table names in ui and added remaining length in meters.
also changed spool selector's spool names.
added tooltip in sidebar to see remaining length in mm
%20-%100 blue
%0-%20 red remaining filament bar
@WildRikku
Copy link
Owner

Hey, thanks for your pull request. I am currently on vacation and will review it afterwards.

@MrBullet
Copy link
Author

Hey, thanks for your pull request. I am currently on vacation and will review it afterwards.

You're welcome! Enjoy your vacation, and take your time reviewing the pull request. Feel free to reach out if you need any clarifications or adjustments when you're back.

@WildRikku WildRikku added the enhancement New feature or request label Jan 2, 2025
@WildRikku WildRikku added this to the 1.8.0 milestone Jan 2, 2025
@WildRikku
Copy link
Owner

I checked out your pull request and I like the idea of displaying more information. I also appreciate the change to meters. However, in the spool tab, the column "Remaining" is now no longer consistent: It shows the total and the remaining weight, but its title is "Remaining".

I would suggest adding a "Total" column instead which would show total weight and length. The total weight would then be removed from the "Remaining" column and could be replaced by the remaining percentage.

This would result in consistent columns:

  • "Total": Total weight and length
  • "Remaining": Remaining percentage, weight and length
  • "Used": Used percentage, weight and length

@WildRikku WildRikku changed the title added remaining length section to ui More information in spool tab and spool selector, progress bar indicator for sidebar Jan 2, 2025
@WildRikku WildRikku added the waiting for OP Feedback from the person who opened the issue is required label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting for OP Feedback from the person who opened the issue is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants