Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for reified constraint #204

Merged
merged 3 commits into from
Dec 8, 2020
Merged

Bugfix for reified constraint #204

merged 3 commits into from
Dec 8, 2020

Conversation

Wikunia
Copy link
Owner

@Wikunia Wikunia commented Dec 8, 2020

Solved #202

There were some pruning possibilities missing in the reified constraint as well as an error in how still_feasible was implemented.

In particular the following things were added:

  • if inner constraint can't be activated it shouldn't be solved
  • if the inner constraint is anti-solved (all fixed but don't fulfill) the reified variable can be set to !activate_on

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #204 (61f461c) into master (a4420cb) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   96.67%   96.77%   +0.10%     
==========================================
  Files          36       36              
  Lines        3066     3072       +6     
==========================================
+ Hits         2964     2973       +9     
+ Misses        102       99       -3     
Impacted Files Coverage Δ
src/constraints/reified.jl 100.00% <100.00%> (ø)
src/ConstraintSolver.jl 99.34% <0.00%> (+0.65%) ⬆️
src/constraints/not_equal.jl 100.00% <0.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4420cb...61f461c. Read the comment docs.

@Wikunia Wikunia merged commit 7fa6558 into master Dec 8, 2020
@Wikunia Wikunia deleted the bugfix-202-reified branch December 8, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant