-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAEA support #164
Draft
erebodino
wants to merge
61
commits into
WhyNotHugo:main
Choose a base branch
from
erebodino:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
CAEA support #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an exepcion, added caea(boolen) field to ReceiptValidation
…ons numbers and modify arguments in serializers _caea to connect to afip
…dified _validate to process creation of ReceiptValidation
…dified _validate to process creation of ReceiptValidation.
for more information, see https://pre-commit.ci
WhyNotHugo
reviewed
Oct 4, 2022
WhyNotHugo
reviewed
Oct 11, 2022
…ipt_pdf on signal
for more information, see https://pre-commit.ci
…a, include a new method fetch_or_create_caea. Refactor conftest to reflect the changes.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
WhyNotHugo
reviewed
Oct 17, 2022
) | ||
|
||
def __str__(self): | ||
return "POS:{}, with CAEA:{}, informed as without movement in {}".format( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we confirm if a Caea
with movements has been informed to AFIP?
WhyNotHugo
reviewed
Oct 17, 2022
…lter actives caeas. Refactor tests,signal and factories
for more information, see https://pre-commit.ci
Co-authored-by: Hugo <[email protected]>
for more information, see https://pre-commit.ci
WhyNotHugo
reviewed
Oct 18, 2022
Thanks for your patience on this one! |
…eipts with same pos and receipt_type
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CAEA support trying to do the minor changes possibles:
Created 3 models to keep track over CAEA:
- Caea itself.
- InformedCaea ( to keep track over the CAEAs without operations informed to AFIP).
- CaeaCounter (to keep track over the number of the receipt created, since this number will be used when AFIP is offline so we must set it before send it).
Modify some field over
Receipt
andReceiptValidation
perhaps is not the best approach but keeps everything very simple to understand.Added a new signal
pre_save
attached toReceipt.save()
to assign CAEA andreceipt_number
when necessary.Modified
TaxPayer
to incorporate new methods to consult/inform CAEA.Modified
ReceiptQrCode
to work with CAEA.Modified PDF generation to allow creation of PDF with CAEA (This receipts will be unvalidated at that moment).
Added some tests to ensure that everything works as expected.