Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sortable pools table #281

Merged

Conversation

BowLover
Copy link
Contributor

@BowLover BowLover commented Jul 5, 2023

Description and Motivation

Added sorting in all columns except incentives and actions.

There are some issues sorting APR in Terra chain. Could be due data types, but apparently is working as intended in other chains so probably is something related to state management.

Same happens on total liquidity. Working as intended in Terra but not in INJ.

Related Issues

I tried to solve Issue #205


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly yarn lint.
  • The project builds and is able to deploy on Netlify yarn build.

@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for exquisite-salamander-a1fe5e ready!

Name Link
🔨 Latest commit 117bf4c
🔍 Latest deploy log https://app.netlify.com/sites/exquisite-salamander-a1fe5e/deploys/64a56ddfa630e20008700ca1
😎 Deploy Preview https://deploy-preview-281--exquisite-salamander-a1fe5e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

0xFable
0xFable previously approved these changes Jul 7, 2023
Copy link
Contributor

@0xFable 0xFable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ready to merge just want to ensure 1 thing is intended

@@ -6,7 +6,7 @@ const Index = () => {
const router: NextRouter = useRouter()

useEffect(() => {
router.replace('/dashboard')
router.replace('/terra/dashboard')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right ser? Can merge if so only thing that stood out

@0xFable 0xFable dismissed their stale review July 7, 2023 15:01

The merge-base changed after approval.

@0xFable 0xFable merged commit e5c5a8a into White-Whale-Defi-Platform:main Jul 7, 2023
@BowLover BowLover deleted the feat/sortable-pools-table branch July 7, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants