Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reward-progress-bar): fixed wrong duration #227

Merged
merged 2 commits into from
May 3, 2023
Merged

fix(reward-progress-bar): fixed wrong duration #227

merged 2 commits into from
May 3, 2023

Conversation

worrex
Copy link
Contributor

@worrex worrex commented May 3, 2023

Adjusted duration string so that it takes single time units into account

Description and Motivation

Related Issues

Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly yarn lint.
  • The project builds and is able to deploy on Netlify yarn build.

@worrex
fix(reward-progress-bar): fixed wrong duration
559977b 
Adjusted duration string so that it takes single time units into account
@netlify
Copy link

netlify bot commented May 3, 2023 •
edited
Loading

✅ Deploy Preview for exquisite-salamander-a1fe5e ready!

Name Link
🔨 Latest commit 8dd047f
🔍 Latest deploy log https://app.netlify.com/sites/exquisite-salamander-a1fe5e/deploys/6452808c42559800083c1e8f
😎 Deploy Preview https://deploy-preview-227--exquisite-salamander-a1fe5e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@0xFable 0xFable enabled auto-merge (squash) May 3, 2023 16:49
0xFable
0xFable approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@0xFable 0xFable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice small change. 🚀

util/conversion/conversion.ts Show resolved Hide resolved
@0xFable 0xFable merged commit 7ccf350 into main May 3, 2023
@Sen-Com Sen-Com deleted the fix/reward-progress-bar branch August 24, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFable 0xFable 0xFable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worrex @0xFable