Spawn a shell for more reliable execution of yarn on some platforms. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WesSouza
force-pushed
the
robust-spawn
branch
3 times, most recently
from
8b7b312 to
1f62b6c
Compare
|
I've rebased the PR to v3.0.0 to include #20, and also added a local GitHub Action for Windows, but it will need further debugging to make it work apparently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried building lgtv-ip-control on Windows as I'm using my C2 as a gaming monitor. It was unable to launch yarn as Windows as it's invoked via yarn.cmd and Windows requires a shell to run .cmd scripts. The Node documentation recommends having the spawn command launch an OS-specific shell for you by simply passing the "shell: true" option.