Fixes #14: not found when KvK number starts with 0

Werkspot · Feb 18, 2019 · 03e44e9 · 03e44e9
1 parent 385f883
commit 03e44e9
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -27,7 +27,7 @@ use Werkspot\KvkApi\ClientFactory;
 $client = ClientFactory::create('<YOUR_API_KEY>', new Production());
 
 $profileQuery = new ProfileQuery();
-$profileQuery->setKvkNumber(18079951);
+$profileQuery->setKvkNumber('18079951');
 
 $kvkPaginator = $client->getProfile($profileQuery);
 

diff --git a/src/Http/Search/ProfileQuery.php b/src/Http/Search/ProfileQuery.php
@@ -8,7 +8,7 @@ final class ProfileQuery implements QueryInterface
 {
     /**
      * @info KvK number, identifying number for a registration in the Netherlands Business Register. Consists of 8 digits
-     * @var int
+     * @var string
      */
     private $kvkNumber;
 
@@ -55,12 +55,12 @@ final class ProfileQuery implements QueryInterface
      */
     private $q;
 
-    public function getKvkNumber(): int
+    public function getKvkNumber(): string
     {
         return $this->kvkNumber;
     }
 
-    public function setKvkNumber(int $kvkNumber): void
+    public function setKvkNumber(string $kvkNumber): void
     {
         $this->kvkNumber = $kvkNumber;
     }

diff --git a/tests/Integration/ClientTest.php b/tests/Integration/ClientTest.php
@@ -19,7 +19,7 @@ final class ClientTest extends TestCase
      * @test
      * @dataProvider getKvkNumbers
      */
-    public function getProfile(int $kvkNumber): void
+    public function getProfile(string $kvkNumber): void
     {
         $client = KvkClientFactory::create('', new Testing());
 
@@ -39,7 +39,7 @@ public function getProfile(int $kvkNumber): void
      * @dataProvider getNonExistingKvkNumbers
      * @expectedException \Werkspot\KvkApi\Http\Adapter\Guzzle\Exception\NotFoundException
      */
-    public function getProfile_shouldThrowException(int $kvkNumber): void
+    public function getProfile_shouldThrowException(string $kvkNumber): void
     {
         $client = KvkClientFactory::create('', new Testing());
 

diff --git a/tests/Unit/Http/Search/ProfileQueryTest.php b/tests/Unit/Http/Search/ProfileQueryTest.php
@@ -16,7 +16,7 @@ final class ProfileQueryTest extends TestCase
      * @test
      * @dataProvider getInteger
      */
-    public function setKvkNumber(int $int): void
+    public function setKvkNumber(string $int): void
     {
         $profileQuery = new ProfileQuery();
         $profileQuery->setKvkNumber($int);