Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate raw TRMF implementation into PyPOTS #560

Merged
merged 7 commits into from
Feb 7, 2025
Merged

Integrate raw TRMF implementation into PyPOTS #560

merged 7 commits into from
Feb 7, 2025

Conversation

WenjieDu
Copy link
Owner

@WenjieDu WenjieDu commented Feb 7, 2025

What does this PR do?

  1. fixing Add TRMF #557 and add testing cases for TRMF;
  2. updating docs;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@coveralls
Copy link
Collaborator

coveralls commented Feb 7, 2025

Pull Request Test Coverage Report for Build 13194790769

Details

  • 150 of 155 (96.77%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 84.419%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/imputation/trmf/model.py 39 44 88.64%
Totals Coverage Status
Change from base Build 12015227701: 0.1%
Covered Lines: 12196
Relevant Lines: 14447

💛 - Coveralls

@WenjieDu WenjieDu merged commit 844fd80 into main Feb 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants