Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip multi-gpu test if not multi-gpu host #124

Merged
merged 2 commits into from
May 21, 2023

Conversation

MaciejSkrabski
Copy link
Contributor

What does this PR do?

Fixes #123 (issue)
If tests are run with a brutal global pytest, they fail if the host machine has less than two cuda-enabled devices. This is almost expected, since we want to test multi-gpu behaviour, but this makes local development difficult on laptops or zero/single gpu machines.
I propose skipping the module alltogether if the machine has less than two cuda-enabled devices.
As a bonus, I disable the upper cap of 2 cuda devices - let's test all of them!

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case. Running tests locally fails if host has less than 2 cuda devices #123
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@coveralls
Copy link
Collaborator

coveralls commented May 20, 2023

Pull Request Test Coverage Report for Build 5034155212

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 83.404%

Files with Coverage Reduction New Missed Lines %
pypots/cli/env.py 1 59.18%
pypots/cli/doc.py 2 83.33%
Totals Coverage Status
Change from base Build 5031142452: 0.07%
Covered Lines: 2940
Relevant Lines: 3525

💛 - Coveralls

@WenjieDu WenjieDu merged commit fe5a358 into WenjieDu:dev May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants