Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling: Hamburger menu #5100

Merged
merged 2 commits into from
Dec 26, 2020
Merged

Spelling: Hamburger menu #5100

merged 2 commits into from
Dec 26, 2020

Conversation

comradekingu
Copy link
Contributor

No description provided.

@Fat-Zer
Copy link
Contributor

Fat-Zer commented Dec 26, 2020

The proposed text doesn't give a good enough hint what a "hamburger menu" is. IMHO it's a relatively new term especially for non-english speakers.

If I may, I'd rather suggest something like this:

  • label: Always use hamburger menu
  • help: Always use the hamburger menu (a button on the top right corner with a drop-down list) instead of a normal full-width version of the menu, even if there is enough space on the screen for the last one.

@comradekingu
Copy link
Contributor Author

comradekingu commented Dec 26, 2020

@Fat-Zer I am not saying my suggestion is the best here, but if the user doesn't know what a hamburger menu is, repeating it in the help text isn't going to do anything.

It is nice that there is a indication of where it is, "drop down" somewhat gives away function.
"for the last one" is a conditional element that can be scrapped.
Edit: I tried to improve it a little bit.

@codecov
Copy link

codecov bot commented Dec 26, 2020

Codecov Report

Merging #5100 (0c2128e) into master (ce5193e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5100   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         563      563           
  Lines       43440    43440           
  Branches     4641     4641           
=======================================
  Hits        39929    39929           
  Misses       2344     2344           
  Partials     1167     1167           
Impacted Files Coverage Δ
weblate/wladmin/forms.py 93.02% <ø> (ø)

@nijel nijel merged commit afdbc7f into WeblateOrg:master Dec 26, 2020
@nijel
Copy link
Member

nijel commented Dec 26, 2020

Merged, thanks for your contribution!

@nijel nijel added this to the 4.4.1 milestone Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants