-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds user suggestions in comment section #4094
Conversation
This pull request introduces 1 alert when merging f46796896f65b375eb90e9323e594db5f0d19e75 into 6ef7bc5 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you looked at option of using some existing rich editor component, which would support autocompletion? We want to do more things in the editor....
I did. I was trying my best to implement it minimally. Also, most RTE don't have the @mention support. There is CKEditor which has @mention abilities. There is also Quill which doesn't have @mention directly but has additional npm plugins which can do it. Seems like both the projects are active. Though Quill seems to have more adoption that ckeditor based on github "used_by" stat. |
a8fa64a
to
e9a5497
Compare
I have added the code to show the user suggestion. Need to still add tests. Not sure if documentation will be needed. I would rather add the test once we are sure and happy with the design and workflow. |
This pull request introduces 4 alerts when merging e9a5497ef33df65000614e74b91a20c92a8dba15 into 95fb213 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use yarn to install third-party libs and place them under weblate/static/vendor, see https://docs.weblate.org/en/latest/contributing/frontend.html
Merged, thanks for your contribution! |
It is broken right now as it sens keys to textarea which is hidden by CodeMirror, see #4094
Thanks for catching that. |
Before submitting pull request, please ensure that: