Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Srv 820 #20

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Srv 820 #20

merged 5 commits into from
Oct 30, 2024

Conversation

davidriverapericas
Copy link

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

davidriverapericas
davidriverapericas commented Oct 30, 2024
View reviewed changes
Copy link
Author

@davidriverapericas davidriverapericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now

@davidriverapericas davidriverapericas merged commit 745cdf5 into master Oct 30, 2024
28 of 34 checks passed
@davidriverapericas davidriverapericas deleted the SRV-820 branch October 30, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyohasstium nyohasstium nyohasstium approved these changes

Assignees
No one assigned
Labels
plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidriverapericas @nyohasstium