Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove incorrect accept header for issue or revoke credential #313

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iFergal
Copy link
Contributor

@iFergal iFergal commented Mar 4, 2025

The issue and revoke credential endpoints return an operation like most endpoints, so they should have an application/json content type.

The problem with the client specifying application/json+cesr (which credentials().get(said) can do, but not by default) is the response body is lost if you raise e.g. a falcon.HttpNotFound exception. So if you tried to issue a credential with an unknown registry you would just see HTTP POST /identifiers/issuer/credentials - 404 Not Found - .

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.63%. Comparing base (f59a9ba) to head (4ec081d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
- Coverage   83.64%   83.63%   -0.01%     
==========================================
  Files          48       48              
  Lines        4267     4265       -2     
  Branches     1067     1054      -13     
==========================================
- Hits         3569     3567       -2     
  Misses        668      668              
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iFergal iFergal changed the title fix: remove incorrect accept header for issuing credential fix: remove incorrect accept header for issue or revoke credential Mar 4, 2025
@iFergal
Copy link
Contributor Author

iFergal commented Mar 4, 2025

Not sure why the tests failed on the second commit, passing locally. Seems like a flakey (very rarely) test, should be OK on a re-run. (I can't trigger)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant