Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return 409 if agent already booted #302

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

iFergal
Copy link
Collaborator

@iFergal iFergal commented Oct 9, 2024

I think 409 is more appropriate here, and gives it some separation from the various other 400 responses from this endpoint without relying on text responses which are more subject to change.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.71%. Comparing base (18d3ad7) to head (7cf15df).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
+ Coverage   93.06%   93.71%   +0.65%     
==========================================
  Files          36       36              
  Lines        7121     7941     +820     
==========================================
+ Hits         6627     7442     +815     
- Misses        494      499       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable "The HTTP 409 Conflict client error response status code indicates a request conflict with the current state of the target resource."

@2byrds 2byrds merged commit 19fa3d3 into WebOfTrust:main Oct 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants