Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add the Web Share Target API #46

Merged
merged 2 commits into from
Oct 26, 2021
Merged

✨ Add the Web Share Target API #46

merged 2 commits into from
Oct 26, 2021

Conversation

hkamran80
Copy link
Contributor

This PR adds the Web Share Target API to WebCrate.

Discussed in #29 (comment) and #44.

@BetaHuhn Volta.net
Copy link
Member

Why the change to the copy-templates script?

@BetaHuhn BetaHuhn self-requested a review October 25, 2021 06:11
@hkamran80
Copy link
Contributor Author

I use macOS, and it wouldn't recognize the -r argument to cp.

While -R is posix well-defined, -r is not portable!
On Linux, in the GNU and BusyBox implementations of cp, -r and -R are equivalent.
On the other side, as you can read in the POSIX manual page of cp, -r behavior is implementation-defined.

Source: this Stack Exchange answer

@BetaHuhn
Copy link
Member

Ah okay, makes sense. Didn't know that -r only works on Linux, thanks for the explanation and source!

Will merge this tomorrow and release it with a few other fixes later this or next week.

@hkamran80
Copy link
Contributor Author

No problem! Thank you!

@BetaHuhn BetaHuhn changed the title Add the Web Share Target API ✨ Add the Web Share Target API Oct 26, 2021
@BetaHuhn BetaHuhn merged commit 0e3abf5 into WebCrateApp:master Oct 26, 2021
BetaHuhn added a commit that referenced this pull request Oct 26, 2021
@BetaHuhn
Revert "✨ Add the Web Share Target API (#46)"
57ec3a3 
This reverts commit 0e3abf5.
BetaHuhn added a commit that referenced this pull request Oct 26, 2021
@BetaHuhn
✨ Add the Web Share Target API (#46)
ef5f353 
    Discussed in [#29 (comment)](#29 (comment)) and #44.
BetaHuhn pushed a commit that referenced this pull request Oct 26, 2021
@hkamran80 @BetaHuhn
✨ Add the Web Share Target API (#46)
0e1201a 
    Discussed in [#29 (comment)](#29 (comment)) and #44.
@WebCrateApp WebCrateApp deleted a comment from WebCrateBot Oct 26, 2021
@BetaHuhn BetaHuhn removed the released label Oct 26, 2021
BetaHuhn pushed a commit that referenced this pull request Oct 29, 2021
@hkamran80 @BetaHuhn
🩹 Add the Web Share Target API (#46)
a726371
@WebCrateBot
Copy link
Collaborator

🎉 This PR is included in version 1.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BetaHuhn BetaHuhn BetaHuhn approved these changes

Assignees
No one assigned
Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hkamran80 @BetaHuhn @WebCrateBot