Fix logic errors in the zero-inode path. #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've now tested the zero-inode path on a Wasm engine specially-modified to have `fd_readdir` set inode numbers to zero. Fix two bugs this turned up: - Increment `buffer_processed`, as noticed by @yamt - Don't do an `fstatat` on "..", because that references a path outside of the directory, which gets a permission-denied error.
This was referenced Dec 5, 2022
john-sharratt
pushed a commit
to john-sharratt/wasix-libc
that referenced
this pull request
Mar 6, 2023
I've now tested the zero-inode path on a Wasm engine specially-modified to have `fd_readdir` set inode numbers to zero. Fix two bugs this turned up: - Increment `buffer_processed`, as noticed by @yamt - Don't do an `fstatat` on "..", because that references a path outside of the directory, which gets a permission-denied error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've now tested the zero-inode path on a Wasm engine specially-modified to have
fd_readdirset inode numbers to zero. Fix two bugs this turned up:buffer_processed, as noticed by @yamtfstataton "..", because that references a path outside of the directory, which gets a permission-denied error.