SIMD Integer to floating point conversion implementation. #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binji
reviewed
Mar 6, 2018
| break; | ||
|
|
||
| case Opcode::F64X2ConvertUI64X2: | ||
| CHECK_TRAP(SimdUnop<v128, uint64_t>(SimdConvert<double, uint64_t>)); |
There was a problem hiding this comment.
This case uses wabt_convert_uint64_to_double to handle a floating point rounding issue on windows. Can you do the same here?
lizhengxing
force-pushed
the
simd-float-convert-impl-PR
branch
from
dcdad44 to
468d6b0
Compare
Including: f32x4.convert_s/i32x4 f32x4.convert_u/i32x4 f64x2.convert_s/i64x2 f64x2.convert_u/i64x2
binji
reviewed
Mar 6, 2018
src/interp.cc
Outdated
| break; | ||
|
|
||
| case Opcode::F64X2ConvertUI64X2: | ||
| #if COMPILER_IS_MSVC && defined(_M_X64) |
There was a problem hiding this comment.
Hmm, I'd prefer to keep the #if in config.h.in. I forgot that wabt_convert_* is not a function otherwise. Can you instead convert the macro in config.h.in to an inline function and always use that here? Sorry for the extra effort!
There was a problem hiding this comment.
Sure, I will do that.
There was a problem hiding this comment.
Hm, looking at the appveyor build, it looks like it breaks on Windows. Not quite sure why though.
lizhengxing
force-pushed
the
simd-float-convert-impl-PR
branch
from
468d6b0 to
982a974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including:
f32x4.convert_s/i32x4
f32x4.convert_u/i32x4
f64x2.convert_s/i64x2
f64x2.convert_u/i64x2