Accept duplicate block labels. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, can you add a test? |
|
Test added. |
|
LGTM |
wenyongh
pushed a commit
to wenyongh/wabt
that referenced
this pull request
Jan 30, 2024
* In no-sandbox mode, turn off things that are not needed there. * Render indirect calls directly in no-sandbox mode. * Fix for lint error. * Adjusted tests. * Another try of fixing the tests. * Fix whitespace in tests. * Use needs_initial_comma logic to clarify things a bit. * Implemented review suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ml-proto allows duplicate block labels. This is noted as convenient in the discussions WebAssembly/spec#210 as is supports 'locality and compositionality'. Perhaps something to consider for sexp-wasm.