-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full code for $scheduler1 and $scheduler2 examples #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! Lets run and merge this after #81. |
dhil
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have confirmed (locally) that they both run with the latest version of the reference interpreter.
For scheduler1.wast
I get:
0 : i32
1 : i32
0 : i32
2 : i32
1 : i32
3 : i32
2 : i32
3 : i32
For scheduler2.wast
I get:
0 : i32
1 : i32
0 : i32
2 : i32
1 : i32
3 : i32
2 : i32
3 : i32
which I believe is the expected output.
dhil
pushed a commit
to dhil/wasm-stack-switching
that referenced
this pull request
Jan 15, 2025
This was renamed to kWasmVoid in WebAssembly/memory64@2f5a7c5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The third section of the explainer currently compares task scheduling using
resume
/suspend
vsswitch
using two example modules,$scheduler1
and$scheduler2
. The explainer only contains a skeleton of the actual code.This PR adds
.wast
files containing full code for these modules and links to them in the explainer. The code is carefully written to follow the structure shown in the explainer.The code already follows the syntax update coming in #81.
Based on earlier versions of the code created by @dhil.