Refactored design #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without event instructions Returning from a task function ends it Use regular multi-argument return conventions
|
Closing as there are enough issues with this approach to merit an alternate design |
dhil
added a commit
to dhil/wasm-stack-switching
that referenced
this pull request
Apr 12, 2024
MVar implementation
dhil
added a commit
to dhil/wasm-stack-switching
that referenced
this pull request
Apr 12, 2024
This is a quick pass over the overview document. I have added type annotations and the tag filter list on `resume_throw`. --------- Co-authored-by: Andreas Rossberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential revision of the task-based design.
We have dropped the use of event.switch instruction, together with associated use of event tags.
A task function can return normally; in which case it must return a vector of arguments that matches what it does when suspending.
Resuming a task is analogous; there is a vector of values that encodes the resuming event.
Exceptions are propagated: if a task function throws an exception then the current parent must handle it.
Remaining wart: the task function is both more regular than before and less: it has an additional argument representing the first resume event for the task.
Remaining todo: the task.retire instruction is probably redundant at this point.