Fix the path to the wasm executable to match what the Makefile builds. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis-testscript still creates "main.native" and therefore fails. (A simple "mv main.native wasm" does the trick.) |
|
@pjuftring Fixed, thanks! |
|
I suspect this breaks the `--build` option of the script, unless you also
adapt the `rebuildInterpreter` function. Now that the Makefile is using
ocamlbuild, the function should probably just invoke that instead of
duplicating the parameters.
|
This avoids duplicating the ocamlbuild command-line, and creates an executable named wasm instead of "main.native".
sunfishcode
force-pushed
the
runtests-name
branch
from
131c587 to
c528464
Compare
|
I updated --build to just invoke the Makefile. It Works For Me (tm). |
|
Merging, because it fixes #59 and no one has objected so far. |
sunfishcode
added a commit
that referenced
this pull request
Oct 2, 2015
Fix the path to the wasm executable to match what the Makefile builds.
eqrion
pushed a commit
to eqrion/wasm-spec
that referenced
this pull request
Jul 18, 2019
eqrion
pushed a commit
to eqrion/wasm-spec
that referenced
this pull request
Jul 18, 2019
data.drop must update the store, not the frame. There may be multiple copies of the frame, so any updates will only update once. We can make sure that all copies are updated by using an indirection through data addresses and updating the store instead. See discussion in PR WebAssembly#92.
alexcrichton
pushed a commit
to alexcrichton/spec
that referenced
this pull request
Nov 18, 2019
…ntation-status Update ImplementationStatus for WAVM
rossberg
pushed a commit
that referenced
this pull request
Feb 11, 2021
In the generated test files the generic imports contained a function that does not exist anymore. This caused all tests to fail. This PR removes the function from the imports.
rossberg
pushed a commit
that referenced
this pull request
Nov 6, 2024
rossberg
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #59. I have no idea if it works on Windows. If this fix is inappropriate, please tell me what I can do to fix this instead. Thanks!