Remove unnecessary fences from GSI output #7308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlobalStructInference only optimizes gets of immutable fields, so even if those gets are seqcst, they cannot synchronize with any writes. We were being overly conservative by emitting fences in place of optimized seqcst gets before.
kripken
reviewed
Feb 20, 2025
kripken
approved these changes
Feb 20, 2025
Co-authored-by: Alon Zakai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GlobalStructInference only optimizes gets of immutable fields, so even
if those gets are seqcst, they cannot synchronize with any writes. We
were being overly conservative by emitting fences in place of optimized
seqcst gets before.