Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Avoid v128 in rec groups with no other v128 uses #6843

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

kripken
Copy link
Member

@kripken kripken commented Aug 15, 2024

We don't properly validate that yet. E.g.:

(module
 (rec
  (type $func (func))
  (type $unused (sub (struct (field v128))))
 )
 (func $func (type $func))
)

That v128 is not used, but it ends up in the output because it is in a rec group that is used.
Atm we do not require that SIMD be enabled in such a case, which can trip up the fuzzer.

Context: #6820 (comment) For now, modify the test that uncovered this.

@kripken kripken merged commit c2b4380 into WebAssembly:main Aug 15, 2024
13 checks passed
@kripken kripken deleted the hacktest branch August 15, 2024 23:24
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants