TupleOptimization: Properly handle subtyping in copies #6786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Jul 25, 2024
src/passes/TupleOptimization.cpp
Outdated
| @@ -320,8 +320,13 @@ struct TupleOptimization : public WalkerPass<PostWalker<TupleOptimization>> { | |||
| // we were confused earlier and the target should not be. | |||
| assert(sourceBase); | |||
|
|
|||
| // The source and target may have different lane types due to subtyping | |||
There was a problem hiding this comment.
Usually we use "element" rather than "lane" to describe tuple elements. ("lane" is specific to SIMD vectors.)
There was a problem hiding this comment.
Thanks, fixed. Also fixed some existing appearances.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used the target's type for the read from the source, but due to subtyping those
might be different.
Found by the fuzzer.