Heap2Local: Properly handle failing array casts #6772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Jul 18, 2024
| @@ -1050,6 +1062,30 @@ struct Array2Struct : PostWalker<Array2Struct> { | |||
| builder.makeConst(Literal(result)))); | |||
| } | |||
|
|
|||
| void visitRefCast(RefCast* curr) { | |||
There was a problem hiding this comment.
Does the comment saying "this is not a problem for ref.cast" above need to be edited?
There was a problem hiding this comment.
Good catch, fixed.
The cast does go away when we optimize, but now that we allow casts to fail, we do need to know if it fails or not...
Co-authored-by: Thomas Lively <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #6727 which added support for failing casts in Struct2Local, but it
turns out that it required Array2Struct changes as well. Specifically, when we
turn an array into a struct then casts can look like they behave differently
(what used to be an array input, becomes a struct), so like with RefTest that we
already handled, check if the cast succeeds in the original form and handle
that.
Found by the fuzzer.