Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert memory64 lowering test to lit. NFC #6731

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Convert memory64 lowering test to lit. NFC #6731

merged 1 commit into from
Jul 11, 2024

Conversation

sbc100
Copy link
Member

@sbc100 sbc100 commented Jul 11, 2024

Test was converted using port_passes_tests_to_lit.py.

@sbc100 sbc100 requested review from tlively and kripken July 11, 2024 21:00
tlively
tlively approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this would be broken up into smaller functions so the output would be alongside the relevant input, but that's a heavier lift than just running the porting script.

@sbc100
Convert memory64 lowering test to lit. NFC
1271948 
Test was converted using port_passes_tests_to_lit.py.
@sbc100 sbc100 force-pushed the memory64_lowering_test branch from 6ffde47 to 1271948 Compare July 11, 2024 21:41
@sbc100
Copy link
Member Author

sbc100 commented Jul 11, 2024

I broke it up!

@sbc100 sbc100 enabled auto-merge (squash) July 11, 2024 21:42
tlively
tlively approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@sbc100 sbc100 disabled auto-merge July 11, 2024 22:09
@sbc100 sbc100 merged commit 363edc7 into main Jul 11, 2024
13 checks passed
@sbc100 sbc100 deleted the memory64_lowering_test branch July 11, 2024 22:09
@gkdn gkdn mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

@tlively tlively tlively approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbc100 @kripken @tlively