-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WasmGC] Heap2Local: Optimize RefIs and RefTest #6705
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
a4e1778
almost
kripken 38f2297
work
kripken 3009f94
work
kripken 10a8b9d
work
kripken 43e5381
Undo.opt
kripken d36281b
re-do
kripken 1c11a1e
Revert "re-do"
kripken 19823a6
format
kripken 078b813
almost
kripken 090af2d
work
kripken 49d7545
Merge remote-tracking branch 'origin/main' into heap2local.ref.eq
kripken 60050be
fix
kripken dea6db5
add two more tests
kripken 9029ba2
improve test
kripken f305e4f
more
kripken 8d26f56
test
kripken cffde15
todo
kripken 66f8b13
work
kripken 72c9b60
test
kripken fd71b16
formt
kripken 4193d58
test
kripken 1eb9848
fix
kripken 56d5e98
merge
kripken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also keep only the operands of other operations we currently drop, which would add the very least make the code more consistent and reduce the number of IR nodes in the output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, looks like that would affect just RefEq. I can do that separately from this PR.