Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Strings] Fix effects of string.compare and add fuzzing #6547

Merged
merged 7 commits into from
Apr 25, 2024
Merged

[Strings] Fix effects of string.compare and add fuzzing #6547

merged 7 commits into from
Apr 25, 2024

Conversation

kripken
Copy link
Member

@kripken kripken commented Apr 25, 2024

We added string.compare late in the spec process, and forgot to add effects for it.
Unlike string.eq, it can trap.

Also use makeTrappingRefUse in recent fuzzer string generation places that I
forgot, which should reduce the amount of traps in fuzzer output.

@kripken kripken requested a review from tlively April 25, 2024 18:37
@kripken kripken merged commit c33f126 into WebAssembly:main Apr 25, 2024
13 checks passed
@kripken kripken deleted the fuzz.string.eq branch April 25, 2024 22:21
@gkdn gkdn mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlively tlively tlively approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kripken @tlively