-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typed continuations: nocont and cont basic heap types #6468
Conversation
The |
Fair enough, I'm happy to keep the old name. I've undone the renaming and updated the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but for more test coverage it might be a good idea to add continuation types to TestHeapTypeRelations
in test/gtest/type-builder.cpp as well.
Good call, I actually caught a place I had forgotten to update this way! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
Just FYI, this was the last missing piece to add basic support for the core of the proposal to binaryen. Only I'd therefore prioritize implementing validation for the already added instructions first. Can the new wat/wast parser now be used for spec tests, or is that going to be the case soon-ish? I'm asking because I'm hoping to re-use our existing spec tests when adding validation, rather than having to transform them into binaryen's text format. |
No support for running spec tests with the new parser yet, but I hope to be done with that within a couple weeks. |
@frank-emrich, the new parser is now used for top-level modules in wasm-shell, so you should try running your spec tests now. It's possible you'll run into some other limitations, but at least there should be fewer now. I plan to keep working toward being able to run the full upstream test suite. |
That's great, thanks for letting me know! |
This PR is part of a series that adds basic support for the typed continuations/wasmfx proposal.
This particular types adds
cont
andnocont
as top and bottom types for continuation types, completely analogous tofunc
andnofunc
for function types (also:exn
andnoexn
).