[Strings] Implement TODOs in the fuzzer #6416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Mar 21, 2024
| case HeapType::stringview_iter: | ||
| WASM_UNREACHABLE("TODO: strings"); | ||
| return builder.makeStringAs( | ||
| StringAsIter, makeBasicRef(Type(HeapType::string, NonNullable))); |
There was a problem hiding this comment.
Don't we have separate heap types for all the different stringref views and iterators?
There was a problem hiding this comment.
Yes, there are three cases here, stringview_wtf8, wtf16, iter - ? I'm not sure what else you expect to see, sorry.
There was a problem hiding this comment.
Oh, I think I was confusing HeapType::string for the output type of the expression rather than the input type.
tlively
approved these changes
Mar 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.