feat!: add support for BinaryenArrayNewData #6236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Vergnaud <[email protected]>
|
Fixes #5270 |
kripken
reviewed
Jan 24, 2024
|
Done, but the workflow is blocked, so not sure if the test succeeds |
|
I ran the workflow here. But it will be faster to debug locally, which you can do with |
Signed-off-by: Eric Vergnaud <[email protected]>
|
@kripken done, hopefully my last push will fix all failures |
|
btw what is the option for building the binaryen wasm module with dwarf attached such that I can understand the failing assertions (when using validate on a "manually" built module) ? The readme says it's supported, but not how... |
|
I think making a debug build should be enough. So something like |
kripken
approved these changes
Jan 25, 2024
|
A debug build definitely provides a lot more info. Looks like dwarf is embedded, but unfortunately it's not used by my debugger (it works with map files)... |
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.