Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RefNull issues #3123

Merged
merged 3 commits into from
Sep 13, 2020
Merged

Fix RefNull issues #3123

merged 3 commits into from
Sep 13, 2020

Conversation

dcodeIO
Copy link
Contributor

@dcodeIO dcodeIO commented Sep 12, 2020

  • ExpressionAnalyzer: Fix ref.null ht equality check to include ht.
  • Precompute: Fix ref.null ht expression reuse to also update ht.
  • Fuzzing: Fix ref.null func becoming canonicalized to ref.func $funcref
    when evaluating execution results, by adding a check for isNull.
  • Fuzzing: Print actual and expected execution results when aborting.
  • Tests: Update if-arms-subtype test in optimize-instructions to check
    that identical if arms become folded while not identical arms are kept.

Fixes #3119

@dcodeIO
Copy link
Contributor Author

dcodeIO commented Sep 12, 2020

Invocations so far:
   FuzzExec: 44857
   CompareVMs: 12290
   CheckDeterminism: 3898
   Wasm2JS: 10750
   Asyncify: 11362

ITERATION: 52628

Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @aheejin's comment about the test addressed.

@dcodeIO dcodeIO merged commit 643facd into WebAssembly:master Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue found by fuzzer
3 participants