Move Type-related functions into Type class (NFC) #2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aheejin
force-pushed
the
type_method_refactor
branch
2 times, most recently
from
a39dcda to
2be26a2
Compare
aheejin
changed the title
Several type-related functions currently exist outside of `Type` class and thus in the `wasm`, effectively global, namespace. This moves these functions into `Type` class, making them either member functions or static functions. Also this renames `getSize` to `getByteSize` to make it not to be confused with `size`, which returns the number of types in multiple types. This also reorders the order of functions in `wasm-type.cpp` to match that of `wasm-type.h`.
aheejin
force-pushed
the
type_method_refactor
branch
from
2be26a2 to
944ae89
Compare
kripken
approved these changes
Dec 29, 2019
src/wasm-type.h
Outdated
|
|
||
| // Reinterpret an integer type to a float type with the same size and vice | ||
| // versa. Only single integer and float types are supported. | ||
| Type reinterpretType() const; |
There was a problem hiding this comment.
This can be just reinterpret I think, as that it's on a Type is now implicit?
src/wasm-type.h
Outdated
| FeatureSet getFeatures() const; | ||
|
|
||
| // Returns a type based on its size in bytes and whether it is a float type. | ||
| static Type getType(unsigned byteSize, bool float_); |
There was a problem hiding this comment.
likewise this can be Type::get()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several type-related functions currently exist outside of
Typeclass and thus in the
wasm, effectively global, namespace. This movesthese functions into
Typeclass, making them either member functionsor static functions.
Also this renames
getSizetogetByteSizeto make it not to beconfused with
size, which returns the number of types in multipletypes. This also reorders the order of functions in
wasm-type.cpptomatch that of
wasm-type.h.