Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name section changes #914

Closed
kripken opened this issue Feb 17, 2017 · 2 comments
Closed

Name section changes #914

kripken opened this issue Feb 17, 2017 · 2 comments

Comments

@kripken
Copy link
Member

kripken commented Feb 17, 2017 •
edited
Loading

Wasm is changing the Name section, WebAssembly/design#984, which we use when we emit code with -g. We should update our binary read/write code for that.
@lukewagner
Copy link
Member

Politely requesting a ping whenever this change is ready to land so we can update browsers simultaneously. Because it's a custom section it's not a "breaking" change, but still it'd be nice to minimize the window of not-working-ness.

pipcet added a commit to pipcet/binaryen that referenced this issue Mar 6, 2017
@pipcet
extensible name section support
9bf8e9b 
See WebAssembly#914.
@pipcet pipcet mentioned this issue Mar 6, 2017
Merged
dschuff pushed a commit that referenced this issue Apr 13, 2017
@pipcet @dschuff
Extensible name section (#933)
57a2bb9 
See #914.

* extensible name section support: read function names, too

* c-api-unused-mem.txt: change expected size to match new name section

* * check subsection size matches

* print warning for unknown name subsections (including the local
  section)
@tlively
Copy link
Member

tlively commented Jan 13, 2025

Not sure whether Luke ever got his ping, but he surely isn't still waiting on it. The name section has been stable for a long time now.

@tlively tlively closed this as completed Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kripken @tlively @lukewagner