Skip to content

Commit

Permalink
JS Bindings: Use stringToUTF8OnStack instead of deprecated allocateUT…
Browse files Browse the repository at this point in the history
…F8OnStack (#6324)

This avoids a warning on recent Emscripten.
  • Loading branch information
kripken authored Feb 20, 2024
1 parent c0cdd26 commit d0fa710
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ if(EMSCRIPTEN)
target_link_libraries(binaryen_wasm "-sEXPORT_NAME=Binaryen")
target_link_libraries(binaryen_wasm "-sNODERAWFS=0")
target_link_libraries(binaryen_wasm "-sEXPORT_ES6")
target_link_libraries(binaryen_wasm "-sEXPORTED_RUNTIME_METHODS=allocateUTF8OnStack,stringToAscii")
target_link_libraries(binaryen_wasm "-sEXPORTED_RUNTIME_METHODS=stringToUTF8OnStack,stringToAscii")
target_link_libraries(binaryen_wasm "-sEXPORTED_FUNCTIONS=_malloc,_free")
target_link_libraries(binaryen_wasm "--post-js=${CMAKE_CURRENT_SOURCE_DIR}/src/js/binaryen.js-post.js")
target_link_libraries(binaryen_wasm "-msign-ext")
Expand Down Expand Up @@ -500,7 +500,7 @@ if(EMSCRIPTEN)
else()
target_link_libraries(binaryen_js "-sEXPORT_ES6=1")
endif()
target_link_libraries(binaryen_js "-sEXPORTED_RUNTIME_METHODS=allocateUTF8OnStack,stringToAscii")
target_link_libraries(binaryen_js "-sEXPORTED_RUNTIME_METHODS=stringToUTF8OnStack,stringToAscii")
target_link_libraries(binaryen_js "-sEXPORTED_FUNCTIONS=_malloc,_free")
target_link_libraries(binaryen_js "--post-js=${CMAKE_CURRENT_SOURCE_DIR}/src/js/binaryen.js-post.js")
# js_of_ocaml needs a specified variable with special comment to provide the library to consumers
Expand Down
2 changes: 1 addition & 1 deletion src/js/binaryen.js-post.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function preserveStack(func) {
}

function strToStack(str) {
return str ? allocateUTF8OnStack(str) : 0;
return str ? stringToUTF8OnStack(str) : 0;
}

function i32sToStack(i32s) {
Expand Down

0 comments on commit d0fa710

Please sign in to comment.