simpler convert_to_hash function

[robmbrooks]

if real_size is zero, ie

:key => 'foo'
:value => 'bar'

convert_to_hash creates 'foo '=> {} rather than 'foo' => 'bar'

[pierresouchay]

@robmbrooks Can you rebase to let Travis tests pass?

[robmbrooks]

@pierresouchay let me know if this works for you!

[pierresouchay]

@robmbrooks Can you please explain a bit the context?

When is the behavior problematic?

[robmbrooks]

@pierresouchay

If you create a key of foo in consul with a value of bar, the convert_to_hash function returns foo => {}.

The issue being that real_size = 0, so this code never gets to assign item[:value]

        real_size = split_up.size - 1
        (0..real_size).each do |i|
          if i.zero?
            temp = {}
            sub_hash[split_up[i]] = temp
            next
          end
          if i == real_size
            temp[split_up[i]] = item[:value]
          else

[robmbrooks]

@pierresouchay

I've added an rspec test that tests for the issue within the pull request

[pierresouchay]

@robmbrooks Thank you for the Unit test, this is now self-explanatory :-)