Mark AddMethodBodySegments and AddFieldRvaSegments virtual

Washi1337 · Jan 28, 2025 · 166b541 · 166b541 · github-actions · Jan 28, 2025
1 parent 8e2819c
commit 166b541
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 8 deletions.
diff --git a/src/AsmResolver.PE/Builder/ManagedPEFileBuilder.cs b/src/AsmResolver.PE/Builder/ManagedPEFileBuilder.cs
@@ -374,11 +374,16 @@ private void ProcessRvasInMetadataTables(PEFileBuilderContext context)
             return;
         }
 
-        AddMethodBodiesToTable(context, tablesStream);
-        AddFieldRvasToTable(context, tablesStream);
+        AddMethodBodySegments(context, tablesStream);
+        AddFieldRvaSegments(context, tablesStream);
     }
 
-    private void AddMethodBodiesToTable(PEFileBuilderContext context, TablesStream tablesStream)
+    /// <summary>
+    /// Adds all method bodies referenced by the method metadata table to the PE file.
+    /// </summary>
+    /// <param name="context">The context for the new PE file.</param>
+    /// <param name="tablesStream">The tables stream to get the method body RVAs from.</param>
+    protected virtual void AddMethodBodySegments(PEFileBuilderContext context, TablesStream tablesStream)
     {
         var methodTable = tablesStream.GetTable<MethodDefinitionRow>();
         for (uint rid = 1; rid <= methodTable.Count; rid++)
@@ -416,7 +421,12 @@ private void AddMethodBodiesToTable(PEFileBuilderContext context, TablesStream t
         return null;
     }
 
-    private void AddFieldRvasToTable(PEFileBuilderContext context, TablesStream tablesStream)
+    /// <summary>
+    /// Adds all segments referenced by the FieldRva metadata table to the PE file.
+    /// </summary>
+    /// <param name="context">The context for the new PE file.</param>
+    /// <param name="tablesStream">The tables stream to get the Field RVAs from.</param>
+    protected virtual void AddFieldRvaSegments(PEFileBuilderContext context, TablesStream tablesStream)
     {
         var directory = context.Image.DotNetDirectory!;
 

diff --git a/src/AsmResolver.PE/Builder/UnmanagedPEFileBuilder.cs b/src/AsmResolver.PE/Builder/UnmanagedPEFileBuilder.cs
@@ -595,11 +595,16 @@ private void ProcessRvasInMetadataTables(BuilderContext context)
         if (tablesStream is null)
             return;
 
-        AddMethodBodiesToTable(context, tablesStream);
-        AddFieldRvasToTable(context, tablesStream);
+        AddMethodBodySegments(context, tablesStream);
+        AddFieldRvaSegments(context, tablesStream);
     }
 
-    private void AddMethodBodiesToTable(BuilderContext context, TablesStream tablesStream)
+    /// <summary>
+    /// Adds all method bodies referenced by the method metadata table to the PE file.
+    /// </summary>
+    /// <param name="context">The context for the new PE file.</param>
+    /// <param name="tablesStream">The tables stream to get the method body RVAs from.</param>
+    protected virtual void AddMethodBodySegments(BuilderContext context, TablesStream tablesStream)
     {
         var methodTable = tablesStream.GetTable<MethodDefinitionRow>();
         for (uint rid = 1; rid <= methodTable.Count; rid++)
@@ -637,7 +642,12 @@ private void AddMethodBodiesToTable(BuilderContext context, TablesStream tablesS
         return null;
     }
 
-    private void AddFieldRvasToTable(BuilderContext context, TablesStream tablesStream)
+    /// <summary>
+    /// Adds all segments referenced by the FieldRva metadata table to the PE file.
+    /// </summary>
+    /// <param name="context">The context for the new PE file.</param>
+    /// <param name="tablesStream">The tables stream to get the Field RVAs from.</param>
+    protected virtual void AddFieldRvaSegments(BuilderContext context, TablesStream tablesStream)
     {
         var directory = context.Image.DotNetDirectory!;