patch to PR1509 related to the write tasks per group update #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the UFS model hash to the version as of 2023 Apr 17. Some associated changes accompany this update - Restart filenames for MOM6 (ufs-community/ufs-weather-model#1599) - Remove store coriolis setting from MOM6 namelist (ufs-community/ufs-weather-model#1599) - Change in atm 'log' file names (ufs-community/ufs-weather-model#1704) - Additions to diag_table for frozen species (ufs-community/ufs-weather-model#1529) - Restart quilting (ufs-community/ufs-weather-model#1633) - Update to post itag (ufs-community/ufs-weather-model#1690) The switch to restart quilting adds an additional constraint on the size of write groups to be divisible by the number of tiles, so all were increased to the next multiple of 6. In the process of updating the diag tables, unused tables were removed. Closes NOAA-EMC#1445 Closes NOAA-EMC#1499 Partially addresses NOAA-EMC#1277 See also NOAA-EMC#1500
DA does not need the 2D frozen fields. Refs: #
|
@junwang-noaa Would you please verify this is what you expect and in line with our discussion? |
WalterKolczynski-NOAA
force-pushed
the
feature/ufs_update
branch
from
1b58c7e to
7c3b4b7
Compare
WalterKolczynski-NOAA
approved these changes
Apr 26, 2023
WalterKolczynski-NOAA
merged commit ce8117e
into
WalterKolczynski-NOAA:feature/ufs_update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@junwang-noaa says that the entry for
WRTTASK_PER_GROUPthat goes intomodel_configureshould be the total ranks times threads.So the specification at the user level in
config.ufsshould be at a per thread basis.Calculations are updated.