Skip to content

Commit

Permalink
Remove retired AWIPS job from rocoto generation
Browse files Browse the repository at this point in the history
Removes the awips_g2 job to complete the work begun in NOAA-EMC#2547

Resolves NOAA-EMC#2445
  • Loading branch information
WalterKolczynski-NOAA committed May 7, 2024
1 parent d063fb7 commit 17cb726
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 55 deletions.
2 changes: 1 addition & 1 deletion workflow/applications/gfs_cycled.py
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ def get_task_names(self):
gfs_tasks += ['gempakpgrb2spec']

if self.do_awips:
gfs_tasks += ['awips_20km_1p0deg', 'awips_g2', 'fbwind']
gfs_tasks += ['awips_20km_1p0deg', 'fbwind']

if self.do_mos:
gfs_tasks += ['mos_stn_prep', 'mos_grd_prep', 'mos_ext_stn_prep', 'mos_ext_grd_prep',
Expand Down
2 changes: 1 addition & 1 deletion workflow/applications/gfs_forecast_only.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def get_task_names(self):
tasks += ['gempak', 'gempakmeta', 'gempakncdcupapgif', 'gempakpgrb2spec']

if self.do_awips:
tasks += ['awips_20km_1p0deg', 'awips_g2', 'fbwind']
tasks += ['awips_20km_1p0deg', 'fbwind']

if self.do_ocean:
tasks += ['ocean_prod']
Expand Down
11 changes: 0 additions & 11 deletions workflow/prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,17 +113,6 @@ suites:
jgfs_atmos_awips_f( 3,27,6 ):
edits:
TRDRUN: 'NO'
awips_g2:
tasks:
jgfs_atmos_awips_g2_f( 0,64,6 ):
template: jgfs_atmos_awips_g2_master
triggers:
- task: jgfs_atmos_post_f( )
edits:
FHRGRP: '( )'
FHRLST: 'f( )'
FCSTHR: '( )'
TRDRUN: 'YES'
gempak:
tasks:
jgfs_atmos_gempak:
Expand Down
41 changes: 0 additions & 41 deletions workflow/rocoto/gfs_tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -1433,47 +1433,6 @@ def awips_20km_1p0deg(self):

return task

def awips_g2(self):

deps = []
dep_dict = {'type': 'metatask', 'name': f'{self.cdump}atmos_prod'}
deps.append(rocoto.add_dependency(dep_dict))
dependencies = rocoto.create_dependency(dep=deps)

awipsenvars = self.envars.copy()
awipsenvar_dict = {'FHRGRP': '#grp#',
'FHRLST': '#lst#',
'ROTDIR': self.rotdir}
for key, value in awipsenvar_dict.items():
awipsenvars.append(rocoto.create_envar(name=key, value=str(value)))

varname1, varname2, varname3 = 'grp', 'dep', 'lst'
varval1, varval2, varval3 = self._get_awipsgroups(self.cdump, self._configs['awips'])
var_dict = {varname1: varval1, varname2: varval2, varname3: varval3}

resources = self.get_resource('awips')

task_name = f'{self.cdump}awips_g2#{varname1}#'
task_dict = {'task_name': task_name,
'resources': resources,
'dependency': dependencies,
'envars': awipsenvars,
'cycledef': self.cdump.replace('enkf', ''),
'command': f'{self.HOMEgfs}/jobs/rocoto/awips_g2.sh',
'job_name': f'{self.pslot}_{task_name}_@H',
'log': f'{self.rotdir}/logs/@Y@m@d@H/{task_name}.log',
'maxtries': '&MAXTRIES;'
}

metatask_dict = {'task_name': f'{self.cdump}awips_g2',
'task_dict': task_dict,
'var_dict': var_dict
}

task = rocoto.create_task(metatask_dict)

return task

def gempak(self):

deps = []
Expand Down
2 changes: 1 addition & 1 deletion workflow/rocoto/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Tasks:
'verfozn', 'verfrad', 'vminmon',
'metp',
'tracker', 'genesis', 'genesis_fsu',
'postsnd', 'awips_g2', 'awips_20km_1p0deg', 'fbwind',
'postsnd', 'awips_20km_1p0deg', 'fbwind',
'gempak', 'gempakmeta', 'gempakmetancdc', 'gempakncdcupapgif', 'gempakpgrb2spec', 'npoess_pgrb2_0p5deg'
'waveawipsbulls', 'waveawipsgridded', 'wavegempak', 'waveinit',
'wavepostbndpnt', 'wavepostbndpntbll', 'wavepostpnt', 'wavepostsbs', 'waveprep',
Expand Down

0 comments on commit 17cb726

Please sign in to comment.