Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should Throw ArgumentOutOfRangeException for Negative Max Length #72

Closed
WalkerCodeRanger opened this issue Jul 31, 2022 · 1 comment
Closed

Should Throw ArgumentOutOfRangeException for Negative Max Length #72

WalkerCodeRanger opened this issue Jul 31, 2022 · 1 comment
Labels
breaking change bug next-major-version
Milestone
v3.0.0

Comments

@WalkerCodeRanger
Copy link
Owner

Currently, the Parse and TryParse methods do not validate the maxLength argument. So if it is negative, they report that as an error with the version string being too long rather than an argument exception.

This is a breaking change because for Parse it changes the exception type and for TryParse it throws an exception in a case that previously didn't throw an exception.
WalkerCodeRanger added a commit that referenced this issue Jul 31, 2022
@WalkerCodeRanger
Add comments for fixing issue #72
8ec27b0
@WalkerCodeRanger WalkerCodeRanger added this to the v3.0.0 milestone Dec 26, 2022
WalkerCodeRanger added a commit that referenced this issue Jan 22, 2023
@WalkerCodeRanger
SemVersion.Parse and TryParse should throw exception for negative max…
2b19b96 
…Length (issue #72)
@WalkerCodeRanger
Copy link
Owner Author

Fixed in master and will be included with v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change bug next-major-version
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
1 participant
@WalkerCodeRanger