Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow MS Versioning Guidance on Assembly Versions #61

Closed
WalkerCodeRanger opened this issue Jul 16, 2020 · 3 comments
Closed

Follow MS Versioning Guidance on Assembly Versions #61

WalkerCodeRanger opened this issue Jul 16, 2020 · 3 comments
Assignees
@WalkerCodeRanger
Labels
bug
Milestone
v2.1.0 Parsing

Comments

@WalkerCodeRanger
Copy link
Owner

WalkerCodeRanger commented Jul 16, 2020 •
edited
Loading

The open-source library guidance on versioning suggests using only the major version in the assembly version. This appears to have been done for some of the previous assembly versions. When the build was redone, it was set up to match the assembly version to the package version.
@WalkerCodeRanger WalkerCodeRanger added this to the v2.1.0 Parsing milestone Jul 16, 2020
@WalkerCodeRanger WalkerCodeRanger self-assigned this Jul 16, 2020
WalkerCodeRanger added a commit that referenced this issue Dec 30, 2020
@WalkerCodeRanger
update build config to follow MS guidence on assembly versions (issue #…
4355ba6 
…61)
WalkerCodeRanger added a commit that referenced this issue Dec 30, 2020
@WalkerCodeRanger
fix build script changes (issue #61)
ea4678f
WalkerCodeRanger added a commit that referenced this issue Dec 30, 2020
@WalkerCodeRanger
include assembly and file version in project so they can be patched (…
5181a66 
…issue #61)
WalkerCodeRanger added a commit that referenced this issue Dec 30, 2020
@WalkerCodeRanger
try to fix build getting major version number (issue #61)
c20e6c2
WalkerCodeRanger added a commit that referenced this issue Dec 30, 2020
@WalkerCodeRanger
try to force build script major minor patch to be a string (issue #61)
2f6d093
WalkerCodeRanger added a commit that referenced this issue Dec 30, 2020
@WalkerCodeRanger
fix build script split on dot (issue #61)
c0b4ce3
WalkerCodeRanger added a commit that referenced this issue Dec 30, 2020
@WalkerCodeRanger
switch to environment variables for versions (issue #61)
c18c5ec
@WalkerCodeRanger
Copy link
Owner Author

Because packages with assembly versions of 2.0.X.0 have already been published, all future package 2.x assemblies will have assembly version 2.1.0.0.

@WalkerCodeRanger
Copy link
Owner Author

This has been done, but it is being left open to verify when publishing the v2.1.0 release

@WalkerCodeRanger
Copy link
Owner Author

Verified in v2.1.0 release package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WalkerCodeRanger WalkerCodeRanger

Labels
bug
Projects
None yet
Milestone
v2.1.0 Parsing
Development

No branches or pull requests
1 participant
@WalkerCodeRanger