FIX: calibrateThreshold throws IndexOutOfBounds for low LC in combination with relatively few test instances #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oved unnecessary double casts, fixed bracketing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the label cardinality is low and there are few test instances at the same time, calibrateThreshold throws an IndexOutOfBounds Exception.
This PR adds an additional check if to avoid the IndexOutOfBounds Exception by using the mean of the last two obtained probabilities.
Additionally within the existing edge case the bracketing seemed to be wrong and is fixed as well together with the removal of unnecessary casts.